Wireshark mailing list archives
Re: Passing NULL to %s format specifiers
From: Guy Harris <guy () alum mit edu>
Date: Wed, 15 Aug 2012 12:33:02 -0700
On Aug 15, 2012, at 12:10 PM, Guy Harris wrote:
On Aug 15, 2012, at 8:12 AM, Evan Huus wrote:I'm a fan of a macro like Jakub mentioned as part of the old conversation: http://www.wireshark.org/lists/wireshark-dev/201105/msg00205.html...but let's have the macro report a dissector bug if it sees a null pointer. The dissector in question should probably say something other than just "(null)" if whatever routine supplied the pointer failed for some reason.
...or the non-dissector: http://anonsvn.wireshark.org/viewvc?revision=44512&view=revision "unspecified" is better than "(null)" in that context. Perhaps, instead, the macro should take *two* arguments: #define NULL_CHECK(p, substitute) ((p) != NULL ? (p) : (substitute)) and force everybody to decide what the protocol tree item/message/whatever should say if the pointer *is* null. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: Passing NULL to %s format specifiers, (continued)
- Re: Passing NULL to %s format specifiers Jeff Morriss (Aug 15)
- Re: Passing NULL to %s format specifiers mmann78 (Aug 15)
- Re: Passing NULL to %s format specifiers Jeff Morriss (Aug 15)
- Re: Passing NULL to %s format specifiers Evan Huus (Aug 15)
- Re: Passing NULL to %s format specifiers Jakub Zawadzki (Aug 15)
- Re: Passing NULL to %s format specifiers Guy Harris (Aug 15)
- Re: Passing NULL to %s format specifiers Jakub Zawadzki (Aug 16)
- Re: Passing NULL to %s format specifiers Guy Harris (Aug 16)
- Re: Passing NULL to %s format specifiers mmann78 (Aug 15)
- Re: Passing NULL to %s format specifiers Jeff Morriss (Aug 15)
- Re: Passing NULL to %s format specifiers Jeff Morriss (Aug 15)
- Re: Passing NULL to %s format specifiers Guy Harris (Aug 15)
- Re: Passing NULL to %s format specifiers Guy Harris (Aug 15)
- Re: Passing NULL to %s format specifiers Gerald Combs (Aug 16)
- Re: Passing NULL to %s format specifiers Evan Huus (Aug 16)