Wireshark mailing list archives
Re: [Wireshark-commits] rev 44435: /trunk/epan/ /trunk/epan/dissectors/: packet-afp.c packet-ncp2222.inc /trunk/epan/: epan.c expert.c expert.h proto.c proto.h
From: Pascal Quantin <pascal.quantin () gmail com>
Date: Sat, 11 Aug 2012 10:05:51 +0200
Le 11 août 2012 à 08:26, Joerg Mayer <jmayer () loplof de> a écrit :
On Fri, Aug 10, 2012 at 08:33:02PM +0000, gerald () wireshark org wrote:http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44435 User: gerald Date: 2012/08/10 01:33 PM Log: Make the corresponding packet_info available to each tree item. This lets us pass a NULL pinfo to expert_add_info_format() and expert_add_undecoded_item(), which makes it possible to use those routines deep in the bowels of many dissectors. As a proof of concept remove the recent pinfo additions to packet-afp.c. This should also make it easier to fix bug 3884.Does this parameter have any use left? If not we could and should remove it throughout the source including the function header.
Hi, according to my understanding pinfo can be NULL if pi is not NULL. So most of the changes done in r44441 will lead to an expert info not being displayed at all. Regards, Pascal. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 44435: /trunk/epan/ /trunk/epan/dissectors/: packet-afp.c packet-ncp2222.inc /trunk/epan/: epan.c expert.c expert.h proto.c proto.h Joerg Mayer (Aug 10)
- Re: [Wireshark-commits] rev 44435: /trunk/epan/ /trunk/epan/dissectors/: packet-afp.c packet-ncp2222.inc /trunk/epan/: epan.c expert.c expert.h proto.c proto.h Pascal Quantin (Aug 11)