Re: [Wireshark-commits] rev 39143: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dvbci.c

[Dirk Jagdmann <doj () cubic org>]

> So that would be option (c) then?
> c) Define ENC_NA differently from both ENC_LITTLE_ENDIAN and ENC_BIG_ENDIAN.
>
> The impact of this would imply these other changes:
>
> For every proto_tree_add_*() function:
> -> Change the "const gboolean little_endian" argument to something like "gint endian"
> -> Verify "endian" is valid for the given FT_ and choke on invalid ones.
>
> And of course, change all the dissectors to use appropriate ENC_'s in the proto_tree_add_*() function calls.

Even if this is probably a lot of work, I vote for this approach. For the 1.8
release we should emit warnings if FT_ and ENC_ don't match, then for 1.10 emit
error/exceptions, so that eventually all FT_ and ENC_ values express the real
relationship.

-- 
---> Dirk Jagdmann
----> http://cubic.org/~doj
-----> http://llg.cubic.org
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe