Wireshark mailing list archives

Re: Permanent Bytes/Packets handling enhancement in NetFlowV9/IPFIX


From: Guy Harris <guy () alum mit edu>
Date: Tue, 5 Apr 2011 23:23:04 -0700


On Apr 5, 2011, at 11:04 PM, Motonori Shindo wrote:

Anders,

Ooops, my brain seems to stay in the days of 5 years ago, when we used
to post patches on the dev mailing list. I will open the case in
bugzilla. I don't know why the patch doesn't apply. I will check it.

Part of the problem appears to be that, as Jaap noticed, whatever generated the patch failed to run a format string 
through printf or its equivalent:

        Index: epan/dissectors/packet-netflow.c
        ===================================================================
        --- epan/dissectors/packet-netflow.c    (revision 36487)
        +++ epan/dissectors/packet-netflow.c    (working copy)
        @@ -%ld,%ld +%ld,%ld @@

                ...

That *looks* similar to the output of "svn diff"; I don't know what tool it was, or why it appears not to have run "@@ 
-%ld,%ld +%ld,%ld @@" through printf with the line numbers as arguments....
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: