Re: [Wireshark-commits] rev 36659: / /trunk/epan/dissectors/: Makefile.common packet-rohc.c

[Guy Harris <guy () alum mit edu>]

On Apr 19, 2011, at 1:23 PM, Stephen Fisher wrote:

> Coverity has a warning about this code:
>
> Event result_independent_of_operands: (oct & 2) == 1 is always false 
> regardless of the values of its operands (logical operand of if).
> 398           if((oct&0x02)== 1){
>
> Did you mean to bitshift it before the comparison to 1?

Or is this a Boolean flag, so it's just "if (oct & 0x02)" to test whether the bit is set?
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe