Re: [Wireshark-commits] rev 36659: / /trunk/epan/dissectors/: Makefile.common packet-rohc.c

[Stephen Fisher <steve () stephen-fisher com>]

Coverity has a warning about this code:

Event result_independent_of_operands: (oct & 2) == 1 is always false 
regardless of the values of its operands (logical operand of if).
398             if((oct&0x02)== 1){

Did you mean to bitshift it before the comparison to 1?

On Sat, Apr 16, 2011 at 11:44:11AM +0000, etxrab () wireshark org wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=36659
>
> User: etxrab
> Date: 2011/04/16 04:44 AM
>
> Log:
>  Add a basic ROCH dissector.
>  Limitations:
>  - Small CID
>  - RTP profile
>  - IPv4
>
> Directory: /trunk/epan/dissectors/
>   Changes    Path               Action
>   +4 -3      Makefile.common    Modified
>   +984 -0    packet-rohc.c      Added
>
> ___________________________________________________________________________
> Sent via:    Wireshark-commits mailing list <wireshark-commits () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>              mailto:wireshark-commits-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe