Re: fragment_add_..(), pinfo->src/dst, IP vs. TCP Session

[David Aggeler <david_aggeler () hispeed ch>]

I'll probably will create a unique ID for this dissector, but is there 
any desire to handle this in reassemble.c, so other TCP based dissectors 
don't need to reinvent this?
Specially because fragment_hash() already ignores the addresses, I'm 
wondering about the direction of the reassemble module.

David

Am 11.07.2010 18:24, schrieb Bill Meier:
> A suggestion (if you haven't already decided what to do):
> Store a (unique) value with the TCP conversation on which the PDV
> occurs; Use this as the id to fragment_add....
>
> The unique value could be the same as what tcp_dissect_pdus uses: the
> frame number of the first frame containing the PDV.
>
> Or: Use whatever makes sense for you for the unique id....
>
> Bill
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list<wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>               mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
>
>    
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe