Wireshark mailing list archives
Re: Thinking of some changes to packet-scsi.c ...
From: Richard Sharpe <realrichardsharpe () gmail com>
Date: Sat, 4 Dec 2010 14:45:43 -0800
On Sat, Dec 4, 2010 at 6:29 AM, Chris Maynard <Chris.Maynard () gtech com> wrote:
Richard Sharpe <realrichardsharpe@...> writes:If there are any suggestions for other changes, let me know.Hi Richard. It looks like there are other bit-oriented fields besides hf_scsi_control that could benefit from this as well: hf_scsi_inquiry_flags, hf_scsi_modesel_flags, ... There also seem to be a lot of proto_tree_add_text() calls (I count 186 of them). I haven't looked at them all, but I suspect most would be better added using proto_tree_add_item() so those fields could be filterable as well. I saw that you posted a patch on Thursday. Could you open up a bug report and submit the patch(es) there instead? I think it will make it easier to track and the patches won't get lost. Thanks.
I created bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5466 for this since it has nothing to do with iSCSI... The patch I first posted needs reworking so I will not attach it yet. I will attach patches as I get make changes. -- Regards, Richard Sharpe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Thinking of some changes to packet-scsi.c ... Richard Sharpe (Dec 03)
- Re: Thinking of some changes to packet-scsi.c ... Chris Maynard (Dec 04)
- Re: Thinking of some changes to packet-scsi.c ... Anders Broman (Dec 04)
- Re: Thinking of some changes to packet-scsi.c ... Richard Sharpe (Dec 04)
- Re: Thinking of some changes to packet-scsi.c ... ronnie sahlberg (Dec 04)
- Re: Thinking of some changes to packet-scsi.c ... Richard Sharpe (Dec 04)
- Re: Thinking of some changes to packet-scsi.c ... Richard Sharpe (Dec 05)
- Re: Thinking of some changes to packet-scsi.c ... Richard Sharpe (Dec 05)
- Re: Thinking of some changes to packet-scsi.c ... Chris Maynard (Dec 04)