Wireshark mailing list archives
Re: RFC: sorted value_string + bsearch
From: Joerg Mayer <jmayer () loplof de>
Date: Fri, 23 Apr 2010 23:32:26 +0200
On Fri, Apr 23, 2010 at 10:04:30AM -0400, Maynard, Chris wrote:
So, with that in mind ... is there a way, or could there be a way, to verify that certain value string arrays are properly sorted and remain so, perhaps during compilation or at least via a tools/checkXYZ.pl script?
I don't like that approach. If the array is sorted incorrectly, please don't bail out but print a message about the fact and restart but with an extra sorting pass in the beginning. It's bad enough we bail out in many places in the intialization with non-descriptive asserts in proto.c, so please don't add another one. Ciao Joerg -- Joerg Mayer <jmayer () loplof de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: RFC: sorted value_string + bsearch, (continued)
- Re: RFC: sorted value_string + bsearch Anders Broman (Apr 23)
- Re: RFC: sorted value_string + bsearch Jakub Zawadzki (Apr 26)
- Re: RFC: sorted value_string + bsearch Anders Broman (Apr 26)
- Re: RFC: sorted value_string + bsearch Jakub Zawadzki (Apr 26)
- Re: RFC: sorted value_string + bsearch Jakub Zawadzki (Apr 27)
- Re: RFC: sorted value_string + bsearch Anders Broman (Apr 27)
- Re: RFC: sorted value_string + bsearch Jakub Zawadzki (Apr 27)
- Re: RFC: sorted value_string + bsearch Anders Broman (Apr 27)
- Re: RFC: sorted value_string + bsearch Jakub Zawadzki (Apr 27)
- Re: RFC: sorted value_string + bsearch Anders Broman (Apr 27)
- Re: RFC: sorted value_string + bsearch Joerg Mayer (Apr 23)
- Re: RFC: sorted value_string + bsearch Maynard, Chris (Apr 25)