Re: Should the tcpdump tests be run with TZ=GMT0, or should the AFS printer print time stamps in UTC?

[Francois-Xavier Le Bail <devel.fx.lebail () orange fr>]

On 06/08/2018 22:21, Francois-Xavier Le Bail wrote:
> On 06/08/2018 17:17, Francois-Xavier Le Bail wrote:
> > On 06/08/2018 15:09, Francois-Xavier Le Bail wrote:
> > > On 06/08/2018 14:52, Francois-Xavier Le Bail wrote:
> > > > On 06/08/2018 10:42, Denis Ovsienko wrote:
> > > > > Which reminds us that at the end of the day somebody will need to fix the AFS test, whatever is the consensus.
> > > >
> > > > With the rx packet (#4 in the file) showing the problem, in the current printing (CEST),
> > > > the capture time is '23:46:24' and the StoreStatus date is '22:46:24'. difference -1 hour.
> > > > And with TZ=GMT0,
> > > > The capture time is '21:46:24' (-2: OK) and the StoreStatus date is '21:46:24' (-1). same.
> > > >
> > > > Does anyone understand why?
> > > > ---------------------------------------------------------------------------------------------------
> > > > $ ./tcpdump -#ttttnv -r tests/afs.pcap|grep -B1 'StoreStatus date'
> > > > reading from file tests/afs.pcap, link-type EN10MB (Ethernet)
> > > >     4  1999-11-11 23:46:24.151512 IP (tos 0x0, ttl 64, id 57928, offset 0, flags [none], proto UDP
> > > > (17), length 108)
> > > >     131.151.32.21.7001 > 131.151.1.59.7000:  rx data seq 1 ser 433 fs call makedir fid 536871098/1/1
> > > > "tmpdir" StoreStatus date 1999/11/11 22:46:24 group 0 mode 755 (80)
> > > > ---------------------------------------------------------------------------------------------------
> > > > $ TZ=GMT0 ./tcpdump -#ttttnv -r tests/afs.pcap|grep -B1 'StoreStatus date'
> > > > reading from file tests/afs.pcap, link-type EN10MB (Ethernet)
> > > >     4  1999-11-11 21:46:24.151512 IP (tos 0x0, ttl 64, id 57928, offset 0, flags [none], proto UDP
> > > > (17), length 108)
> > > >     131.151.32.21.7001 > 131.151.1.59.7000:  rx data seq 1 ser 433 fs call makedir fid 536871098/1/1
> > > > "tmpdir" StoreStatus date 1999/11/11 21:46:24 group 0 mode 755 (80)
> > >
> > > Perhaps a 'Daylight saving time' reason ... Not sure.
> >
> > Seems a need to reworking printing time in util-print.c. I am looking at it.
>
> Daylight saving time problem confirmed. Update needed. I am working on it.

Should be fixed by:
https://github.com/the-tcpdump-group/tcpdump/commit/d77ac851c76ff95e6542e93715786d29ba86c51f.

-- 
Francois-Xavier
_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers