tcpdump mailing list archives

Re: [Fwd: Re: Thread Safe Lexer]


From: "Gianluca Varenni" <gianluca.varenni () cacetech com>
Date: Thu, 9 Jul 2009 17:54:13 -0700


----- Original Message ----- From: "Guy Harris" <guy () alum mit edu>
To: <tcpdump-workers () lists tcpdump org>
Sent: Thursday, July 09, 2009 5:45 PM
Subject: Re: [tcpdump-workers] [Fwd: Re: Thread Safe Lexer]



On Jul 9, 2009, at 3:34 PM, Gianluca Varenni wrote:

This actually makes sense to me (I actually have the same problem with WinPcap, and I do ship the generated files in the WinPcap source package). Are there any cons to this?

The only potential risk would be if the version of Flex or Bison used to generate the files in the tarballs generated code that wouldn't work on some platforms because, for example, they called routines not available on all supported OSes or versions.

We've been shipping generated lexers and YACC parsers with Wireshark; I don't *think* I remember any problems with people compiling from the tarball, but I might just not be remembering them.

(Note that you'd probably have to ship versions generated on Windows, rather than the UN*X ones that would ship with the libpcap tarball, thanks to Flex's propensity to include <unistd.h> when generating code for UN*X.)

No problem in that, I already regenerate them as part of the build process.

Have a nice day
GV


While we're at it, is there any compelling reason to have the configure scripts and config.h.in files for libpcap and tcpdump (as opposed to the configure.in, aclocal.m4, and acconfig.h files used to generate them) checked into the Git repository? (We don't do that for Wireshark; those generated files aren't checked in.)
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Current thread: