Re: [PATCH] Re: Bug: Counting dropped packets in

[Dustin Spicuzza <dustin () virtualroadside com>]

Guy Harris wrote:
> On Aug 31, 2009, at 2:36 PM, Dustin Spicuzza wrote:
>
> > So... I've changed my patch to populate ps_ifdrop instead, and it should
> > be good to go, without screwing with current applications.
>
> Checked in.

Thanks! Except I found a small problem that I introduced...

If you call linux_if_drops with a NULL device, then it segfaults when it
tries to do strlen(). The only time this happens is if you call
pcap_stats() on a pcap handle that is open but not activated (or the
activation failed), and thus the device is NULL.

Not sure if this is something you want to fix, or if this is in the land
of undefined behavior that the user shouldn't do. :)

Dustin


-- 
Innovation is just a problem away

Attachment: signature.asc
Description: OpenPGP digital signature