Re: [PATCH] Re: Bug: Counting dropped packets in

[Dustin Spicuzza <dustin () virtualroadside com>]

Guy Harris wrote:
> I think that
>
> > +        handle->md.stat.ps_drop += (handle->md.proc_dropped -
> > if_dropped);
>
> and
>
> > +    stats->ps_drop = handle->md.stat.ps_drop;
>
> are wrong, because ps_drop is supposed to reflect the number of packets
> dropped by the packet capture mechanism because they arrived faster than
> the app could consume them, but not the number of packets dropped by the
> adapter or adapter driver before they even made it to the capture
> mechanism.  ps_ifdrop is for the latter (and the comment about it being
> unimplemented is false on Tru64 UNIX, for example, so don't let that
> comment scare you off).

Yeah, my second patch changed it to ps_ifdrop. Unfortunately, the spam
blocker always catches git patches because they have 'index[random
numbers]' in them, so it doesn't show up on the mailing list til someone
approves it...  :)

Dustin

-- 
Innovation is just a problem away

Attachment: signature.asc
Description: OpenPGP digital signature