tcpdump mailing list archives

Re: [Patch/Workaround?] pcap-usb-linux.c


From: "Tyson Key" <tyson.key () gmail com>
Date: Thu, 30 Oct 2008 16:02:37 +0000

Hi Jean-Louis, does libpcap compile with the supplied patch for you?
It applied cleanly here, although I can't complete the ./configure phase
(the error produced is below):
./pcap-usb-linux.c: In function 'usb_read_linux_mmap':
./pcap-usb-linux.c:708: error: 'clen' undeclared (first use in this
function)
./pcap-usb-linux.c:708: error: (Each undeclared identifier is reported only
once
./pcap-usb-linux.c:708: error: for each function it appears in.)
make: *** [pcap-usb-linux.o] Error 1

Thanks.

On Thu, Oct 30, 2008 at 11:48 AM, Jean-Louis <jelot-tcpdump () jelot it> wrote:

Jean-Louis ha scritto:

Jean-Louis ha scritto:

today I have found some bug on pcap-usb-linux.c

now i can try to tell you which are


in accordance with usbmon.txt in "mmap mode" the data is at

&mmap_area[vec[i]] + 64;

rather than

&mmap_area[vec[i]] + 48;

with mmap ther'is 16Byte filled with 0 first to the real data...

so if i.e. I have caplen = 18Byte, in file.pcap I have 16Byte with garbage
(0x00) and only 2Byte with real data other 16Byte of real data is lost.

the mmap mode is *default* with kernel >= 2.6.25-rc8-mm1

I'm newbie with libpcap and I don't know how I can fix that without
degrading performance


I have patched this bug, but seems to be workaround-ish

so now pcap file is ok

-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.




-- 
Fight Internet Censorship! http://www.eff.org
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Open-Source Community, and Technology Testbed: http://www.house404.co.uk/
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Current thread: