[PATCH] cleanup usb_platform_finddevs()

["Abeni Paolo" <paolo.abeni () telecomitalia it>]

hello,

the attached patch cleanup the usb_platform_finddevs(), removing the dependency from debugfs. There are also some other 
minor cleanup in the pcap-usb-linux.c file (unused variables removed and indentation fix).

I plan to post the aligment fix for usb header in a separate patch. The code is ready, but I feel uneasy about it. If I 
set the header aling in the sf_next_packet(), this will be the first data link to use such an hack, right?!? Personally 
I will prefer to enforce the align (little endian) at capture time, but what do you think? 

Just to give some figures, I think that the performance gain related to memory mapped access (which should be disabled 
if the byte ordering is enforced at capture time) should  be roughly 20%-30%. It should be greater when the data block 
exchanged on the usb bus are relativly small, but in such condition the bus bandwith utilization is very sub-optimal.

ciao,

Paolo

--------------------------------------------------------------------

CONFIDENTIALITY NOTICE

This message and its attachments are addressed solely to the persons above and may contain confidential information. If 
you have received the message in error, be informed that any use of the content hereof is prohibited. Please return it 
immediately to the sender and delete the message. Should you have any questions, please contact us by replying to 
webmaster () telecomitalia it.

        Thank you

                                        www.telecomitalia.it

--------------------------------------------------------------------

Attachment: finddevs_fix.patch
Description: finddevs_fix.patch

-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.