Re: Re: -e vs. -x, revisited

[Guy Harris <gharris () sonic net>]

On Wed, Dec 18, 2002 at 12:12:10PM -0800, Guy Harris wrote:
> To handle that, one could have the "xxx_if_print()" routines return the
> link-layer header length.

I've checked in that, and...

> Of course, once we've done *that*, we should probably then do
>
>       void
>       print_packet(u_char *user, const struct pcap_pkthdr *h, const u_char *p)
>       {
>               void (*if_print)(const struct pcap_pkthdr *h, const
>                   u_char *p) = user;
>               u_int hdrlen;
>
>               ++infodelay;
>               ts_print(&h->ts);
>
>               hdrlen = (*user)(h, p);
>               if (xflag)
>                       default_print_packet(p, h->caplen, hdrlen);
>
>               putchar('\n');
>
>               --infodelay;
>               if (infoprint)
>                       info(0);
>       }
>
> and remove all that stuff from the if_print routines, centralizing that
> in "print_packet()" as well.

...that as well.
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe