Re: update on CVE-2008-5718

[Nico Golde <oss-security+ml () ngolde de>]

Hi,
* Thomas Biege <thomas () suse de> [2009-01-14 15:50]:
> On Wed, Jan 14, 2009 at 12:32:07AM +0100, Nico Golde wrote:
> > Hi,
> > I just did a security update for CVE-2008-5718 and since the 
> > description is not really verbose I thought I'd share what I 
> > found in case anyone else is working on that.
> ...
> > Cheers
> > Nico
> > P.S. The patch I used can be found on:
> > http://people.debian.org/~nion/nmu-diff/netatalk-2.0.3-11_2.0.3-11+lenny1.patch
>
> I am not very happy with the patch because it just filters a handful of
> characters, a better solution would be to replace popen().
> (I mentioned this on the netatalk-devel ML but got no answer so far.)

It is no full shell escape but escapes everything that 
should be relevant for command injection. Sure, replacing 
the popen would be the better option but I was not too happy 
doing this as I guess it's more likely to break existing 
functionality with it by accident.

Cheers
Nico
-- 
Nico Golde - http://www.ngolde.de - nion () jabber ccc de - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.

Attachment: _bin
Description: