Re: NSE script: HTTP Debug method

[Paulino Calderon <paulino () calderonpale com>]

Hello Josh,

The script looks good! It is an interesting check for .NET applications we don’t have in NSE yet. I’d like to see a 
couple of improvements before committing this:

-When reading script arguments use the variable SCRIPT_NAME to avoid hardcoding names of scripts in files. 
-Make generate_http_debug_req return a boolean instead of the string ‘enabled’.
-Return output in a structured table or using the NSE library vulns to generate output compatible with XML mode. 
-Include the @xmloutput tag to the documentation

Don’t forget to take a look at https://secwiki.org/w/Nmap/Code_Standards <https://secwiki.org/w/Nmap/Code_Standards> 

Cheers.

> On May 23, 2016, at 5:12 AM, Josh Amishav-Zlatin <jamuse () gmail com> wrote:
>
> Hi,
>
> I attached an NSE script that checks if the remote web server supports the DEBUG method. The script simply sends the 
> stop-debug command and looks for a response body of 'OK'. As this is my first NSE script, I'm very interested in 
> feedback. Updates to the script will be available here:
>
> https://github.com/jamuse/NSE/blob/master/http-debug.nse <https://github.com/jamuse/NSE/blob/master/http-debug.nse>
>
> - Josh
> <http-debug.nse>_______________________________________________
> Sent through the dev mailing list
> https://nmap.org/mailman/listinfo/dev
> Archived at http://seclists.org/nmap-dev/

_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/