Re: 'class FingerMatch' vs 'struct FingerMatch'

[Gisle Vanem <gvanem () yahoo no>]

Daniel Miller wrote:

> Thanks for the catch. This did not cause problems for me on VS 2013, so I didn't catch it. Applied in r34857.

Here are some more VS 2015 (_MSC_VER=1900) warnings:
  NmapOps.h(135): warning C4099: 'FingerPrintDB': type name first seen using 'struct' now seen using 'class'
  osscan2.h(137): warning C4099: 'FingerPrint': type name first seen using 'struct' now seen using 'class'
  osscan.h(184): warning C4099: 'FingerTest': type name first seen using 'class' now seen using 'struct'

And BTW, it's nice to see that the clutter with .h-files has been fixed
in several places lately. But there are still some places where e.g.
<errno.h> gets included *after* Nmap headers. Thus undoing a previous
 '#define EINVAL  WSAEINVAL' etc. in nbase_winunix.h.

The hacks in 'nbase\nbase_winunix.h' to suppress including the real
<errno.h>, doesn't work with the latest Windows Kit. (i.e. here:
"WindowsKits\10\Include\10.0.10056.0\ucrt\errno.h"). I've not checked,
but I belive one *can* use this new Universal CRT with '_MSC_VER < 1800'
too.

--
--gv
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/