Re: [NSE] smb-ls fixes and improvements

[Daniel Miller <bonsaiviking () gmail com>]

On Thu, Apr 30, 2015 at 12:57 PM, Henri Doreau <henri.doreau () gmail com>
wrote:

> 2015-03-23 12:49 GMT+01:00 Henri Doreau <henri.doreau () gmail com>:
> > Hi,
> >
> > Pierre has submitted two pull requests (for this and a NULL-deref) on
> > github. Respectively #89 and #90.
> > Dan: you may want to double check but both PR look good to me and can be
> landed.
> >
>
> I just merged it. Thanks again Pierre.

Henri,

Thanks for looking at this. Since we can't merge directly on Github yet
(still going through Subversion), it is helpful if you include a reference
to the PR or issue in the commit message. Something like "Closes #90" or
"Fixes #90" would have caused the PR to be automatically closed. I've
closed it now, and referenced the appropriate commit.

And thanks, Pierre! I'm sure this improvement will be much-appreciated.

Dan

_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/