Re: [nmap-svn] r34571 - in nmap-exp/pasca1/nmap-nse-socks4a/nsock: . src

[Andrew Jason Farabee <afarabee () uci edu>]

On Wed, Jun 3, 2015 at 4:31 AM, Jacek Wielemborek <d33tah () gmail com> wrote:

> W dniu 03.06.2015 o 13:14, Henri Doreau pisze:
> > A more general concern is the code duplication in your prototype.
> > Nsock proxy code has been architectured with modularity in mind, and
> > to make it easy to reuse code between handlers. Reuse as much as you
> > can from socks4 proxy_spec and only implement the functions that
> > behave differently. This is the exact purpose of the operation
> > vectors.
> >
> > Let me know if you have questions.
> >
> > Regards
>
> Hi Henri,
>
> Andrew basically did what I asked him to - instead of dedicating a lot
> of time looking for clean interfaces, I wanted him to get a "proof of
> concept" working quickly and then we can figure out how to make it look
> better. I hadn't verified the patch yet though, so it might be possible
> that the line you spotted is actually a copy-paste error.
>
> Anyway, thanks for reading the code - we'll definitely need a meeting
> with you once have the general concept working.
>
> Cheers,
> d33tah
Sorry this took so long for me to acknowledge, I must have read the emails
in my sleep. Thanks for spotting that, it's fixed now.

And hopefully the code duplication should be fixed soon too.

Thanks again,
Andrew

_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/