Re: [nmap-svn] r34571 - in nmap-exp/pasca1/nmap-nse-socks4a/nsock: . src

[Henri Doreau <henri.doreau () gmail com>]

Hi,

2015-06-03 2:59 GMT+02:00  <commit-mailer () nmap org>:
> Author: andrew
> Date: Wed Jun  3 00:59:27 2015
> New Revision: 34571
> [...]
> Modified: nmap-exp/pasca1/nmap-nse-socks4a/nsock/src/nsock_proxy.c
> ==============================================================================
> --- nmap-exp/pasca1/nmap-nse-socks4a/nsock/src/nsock_proxy.c    (original)
> +++ nmap-exp/pasca1/nmap-nse-socks4a/nsock/src/nsock_proxy.c    Wed Jun  3 00:59:27 2015
> @@ -281,7 +282,7 @@
>      uri->port = n;
>    } else {
>      uri->port = -1;
> -  }
> + extern const struct proxy_spec ProxySpecSocks4a; }

Huh? Copy/paste error I guess?

A more general concern is the code duplication in your prototype.
Nsock proxy code has been architectured with modularity in mind, and
to make it easy to reuse code between handlers. Reuse as much as you
can from socks4 proxy_spec and only implement the functions that
behave differently. This is the exact purpose of the operation
vectors.

Let me know if you have questions.

Regards

-- 
Henri
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/