Re: [NSE] http-archive.nse

[George Chatzisofroniou <sophron () latthi com>]

Hi guys,

Thank you for testing this.

On Wed, Nov 20, 2013 at 06:44:19PM -0500, Patrick Donnelly wrote: 
> This is very cool. Thanks for coming back and finishing up the
> scripts. My main comment so far is that I'd like to see
> http-archive-liveness depend on http-archive (see [1]). I'd like to
> reduce code repetition. [Unless you have a good reason to keep them
> like this?]

> From what i see, dependencies in NSE are about establishing an ordering of
scripts. But i don't think this is what we want here. We want to be able to
execute http-archive-liveness without running http-archive at all.

To reduce the code repetition we could either 1) make an archive.org crawling
library or 2) merge the two scripts.

On Mon, Nov 25, 2013 at 12:03:33AM -0500, Patrick Donnelly wrote:
> o Lines 141 and 142 (http-archive.nse) should use string.match and not
> string.gmatch (unrelated to bug).

I don't see a "gmatch" statement in none of the scripts.

> o Lines 138 and 139 (http-archive-liveness.nse) are causing the hang
> bug. The initial ".*" in the pattern is unnecessary.

You are right. This prefix was an ugly hack i did to extract the last url from
the HTML response. Apparently, it has some issues.

-- 
George Chatzisofroniou
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/