Re: [nmap-svn] r32398 - in nmap: ncat nsock/src

[David Fifield <david () bamsoftware com>]

On Thu, Sep 26, 2013 at 09:15:19AM -0500, Daniel Miller wrote:
> On 09/26/2013 02:17 AM, commit-mailer () nmap org wrote:
> > -                if ((tmp_name = tempnam(NULL, "ncat.")) == NULL)
> > +                if ((tmp_name = tempfile(NULL, "ncat.")) == NULL)
> >                      bye("Failed to create name for temporary DGRAM source Unix domain socket (tempnam).");
> David,
>
> Should the error message here also be changed, since we're not using
> tempnam any more? If so, should it be "tempfile" or "mkstemp"?

Sure, please go ahead and change it to mkstemp.

I added an implementation of tempfile for Windows using tempnam, but it
isn't called by Ncat because you don't have Unix domain sockets on
Windows.

David Fifield
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/