Re: [PATCH] ncat - make check succeeds despite test failures

[David Fifield <david () bamsoftware com>]

On Thu, Dec 06, 2012 at 07:20:05PM +0100, olli hauer wrote:
> On 2012-12-04 21:44, Andreas Stieger wrote:
> > On 04/12/12 02:53, David Fifield wrote:
> > > On Sun, Dec 02, 2012 at 07:23:04PM +0000, Andreas Stieger wrote:
> > > > I noticed what for ncat, "make check" succeeds despite test failures.
> > > > The attached patch corrects ncat/test/test-addrset.sh  by exiting the
> > > > script with a non-zero return value. If the build system does not have
> > > > name resolution when running tests (as do those of many distribution
> > > > packagers) this will of course fail the tests which use specific domain
> > > > names.
> > > Thanks for this patch. I would prefer not to quit the whole test script
> > > on the first failure. Can you make another patch that sets a flag when a
> > > test fails, and then exits at the end with a status depending on the
> > > flag?
> >
> > Updated patch attached.
> >
> > With kind regards,
> > Andreas Stieger
>
> Hm, the patch has one major issue.
>
> On Platforms where sh != bash let is not available.

I'll accept another patch to fix this. Changeing /bin/sh to /bin/bash is
also acceptable.

David Fifield
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/