Re: [PATCH] ncat - make check succeeds despite test failures

[Andreas Stieger <andreas.stieger () gmx de>]

On 04/12/12 02:53, David Fifield wrote:
> On Sun, Dec 02, 2012 at 07:23:04PM +0000, Andreas Stieger wrote:
> > I noticed what for ncat, "make check" succeeds despite test failures.
> > The attached patch corrects ncat/test/test-addrset.sh  by exiting the
> > script with a non-zero return value. If the build system does not have
> > name resolution when running tests (as do those of many distribution
> > packagers) this will of course fail the tests which use specific domain
> > names.
> Thanks for this patch. I would prefer not to quit the whole test script
> on the first failure. Can you make another patch that sets a flag when a
> test fails, and then exits at the end with a status depending on the
> flag?

Updated patch attached.

With kind regards,
Andreas Stieger

Attachment: nmap-ncat-fail-test-addrset.patch
Description:

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/