Nmap Development mailing list archives

[nsock] superfluous pcap_read_on_nonselect() call


From: Henri Doreau <henri.doreau () gmail com>
Date: Sat, 14 Jul 2012 12:20:41 +0200

Hello,

it looks like the nsock function pcap_read_on_nonselect() is called
even when not needed (i.e.: called on systems that provide selectable
pcap FDs). I would suggest to protect the statement by a #ifndef
PCAP_CAN_DO_SELECT.

I have successfully tested it on linux and freebsd (that both have
selectable pcap FDs), but since this was already in place for a long
time (before nsock-engines) I would appreciate to get this simple
patch (attached) reviewed to avoid introducing a regression.

Regards.

-- 
Henri

Attachment: nsock_pcap_nonselect.diff
Description:

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/

Current thread: