Nmap Development mailing list archives

Re: [PATCH] make clean/distclean not quite clean in libnetutil


From: David Fifield <david () bamsoftware com>
Date: Mon, 18 Jun 2012 07:52:05 -0700

On Mon, Jun 18, 2012 at 03:30:43PM +0100, Michael McTernan wrote:
Hi,

I've found a really minor wrinkle in building where
libnetutil/makefile.dep isn't removed by clean.  Subsequent builds
may then use the wrong dependency info and fail after
reconfiguration since this file doesn't get refreshed.  In my case
I'm cross building for different targets, so changing the include
paths keeps falling over this.

This is with the 6.00 release, but it looks like the problem is
still in https://svn.nmap.org/nmap/libnetutil/Makefile.in and 
https://svn.nmap.org/nmap-releases/nmap-6.01.DARPA1/libnetutil/Makefile.in.

There follows a tiny patch based on my local SVN copy (i.e.
different revision number) which adds makefile.dep to the clean
target; this is the same way as nsock cleans up this file.

Thanks for this suggestion. "distclean" already deletes makefile.dep.
Is deleting dependencies on "clean" really expected behavior? I tried
the GNU Hello demo package. It creates src/.deps/hello/hello.Po after
"./configure"; the deps file isn't deleted by "clean" but is by
"distclean".

Doing cross builds and configuring with different include paths probably
warrants a distclean in between anyway.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/


Current thread: