Nmap Development mailing list archives
[PATCH] make clean/distclean not quite clean in libnetutil
From: Michael McTernan <Michael.McTernan.2001 () cs bris ac uk>
Date: Mon, 18 Jun 2012 15:30:43 +0100
Hi,I've found a really minor wrinkle in building where libnetutil/makefile.dep isn't removed by clean. Subsequent builds may then use the wrong dependency info and fail after reconfiguration since this file doesn't get refreshed. In my case I'm cross building for different targets, so changing the include paths keeps falling over this.
This is with the 6.00 release, but it looks like the problem is still in https://svn.nmap.org/nmap/libnetutil/Makefile.in and https://svn.nmap.org/nmap-releases/nmap-6.01.DARPA1/libnetutil/Makefile.in.
There follows a tiny patch based on my local SVN copy (i.e. different revision number) which adds makefile.dep to the clean target; this is the same way as nsock cleans up this file.
Please consider apply this to ToT and upcoming releases. Kind Regards, Mike Signed-off-by: Michael McTernan <Michael.McTernan.2001 () cs bris ac uk> --- nmap-6.00/libnetutil/Makefile.in (revision 1593) +++ nmap-6.00/libnetutil/Makefile.in (working copy) @@ -25,7 +25,7 @@ $(RANLIB) $@ clean: - rm -f $(OBJS) $(TARGET) + rm -f $(OBJS) $(TARGET) makefile.dep distclean: clean rm -rf Makefile _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- [PATCH] make clean/distclean not quite clean in libnetutil Michael McTernan (Jun 18)
- Re: [PATCH] make clean/distclean not quite clean in libnetutil David Fifield (Jun 18)
- Re: [PATCH] make clean/distclean not quite clean in libnetutil Michael McTernan (Jun 18)
- Re: [PATCH] make clean/distclean not quite clean in libnetutil David Fifield (Jun 18)
- Re: [PATCH] make clean/distclean not quite clean in libnetutil Michael McTernan (Jun 18)
- Re: [PATCH] make clean/distclean not quite clean in libnetutil David Fifield (Jun 18)
- Re: [PATCH] make clean/distclean not quite clean in libnetutil Michael McTernan (Jun 18)
- Re: [PATCH] make clean/distclean not quite clean in libnetutil David Fifield (Jun 19)
- Re: [PATCH] make clean/distclean not quite clean in libnetutil Michael McTernan (Jun 18)
- Re: [PATCH] make clean/distclean not quite clean in libnetutil David Fifield (Jun 18)