Re: [NSE] broadcast-ping

[Gorjan Petrovski <mogi57 () gmail com>]

Thanks. Committed as revision 24626.

On Mon, Jul 4, 2011 at 12:16 AM, Patrick Donnelly <batrick () batbytes com> wrote:
> On Sat, Jul 2, 2011 at 8:59 PM, Gorjan Petrovski <mogi57 () gmail com> wrote:
> > Here is a patch for listing all the interfaces in NSE. Please review
> > it when possible.
>
> Gorjan, the patch looks good but I have a few minor remarks. Please
> fix the formatting for the switch statement. It looks broken in the
> patch. Also, for the error condition where iflist == NULL, you need to
> return 2 instead of 1 because you are returning two values to Lua.
>
> After you have made those adjustments, please commit it.
>
> --
> - Patrick Donnelly



-- 
Gorjan
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/