Re: [PATCH] NSE ipv4 checks

[Henri Doreau <henri.doreau () greenbone net>]

Hello Djalal,

Thank you for the comments.

2011/4/2 Djalal Harouni <tixxdz () opendz org>:
> Thx Henri.
>
> I'm not sure about the path-mtu since I know that PMTU discovery is
> available in IPv6 but perhaps in a different way ?
There is a similar mechanism for IPv6 but path-mtu.nse is not IPv6 compliant.

> Just a small correction in the diff, the debug message of the
> dhcp-discover.nse should use SCRIPT_NAME instead of SCRIPT_FAMILY.
Of course, I don't know where my head was at this day!

> David and others what do you think about this ? my concern is reducing
> scan failures (aborts).
In fact most of these scripts already check that nmap.interface is not
nil, which seems to be enough to discard execution for IPv6 scans (in
my limited testing environment at least). This prevent them for
failing noisily, but it's somewhat "magic" and might change soon. I
think that these IPv4 checks make the things cleaner.

> --
> tixxdz
> http://opendz.org

Regards.

-- 
Henri Doreau |  Greenbone Networks GmbH  |  http://www.greenbone.net
Neuer Graben 17, 49074 Osnabrueck, Germany | AG Osnabrueck, HR B 202460
Executive Directors: Lukas Grunwald, Dr. Jan-Oliver Wagner
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/