Re: [PATCH] NSE ipv4 checks

[David Fifield <david () bamsoftware com>]

On Mon, Mar 28, 2011 at 10:52:41PM +0200, Henri Doreau wrote:
> 2011/3/27 Djalal Harouni <tixxdz () opendz org>:
> > Speaking about NSE IPv6, there are some scripts which assume that they
> > are running in the IPv4 mode even if the '-6' option was specified. This
> > is buggy code.
> >
> > Scripts that are using protocols which are available _only_ in one mode
> > IPv4 or IPv6, can call the nmap.address_family() function, check the
> > returned string 'inet' or 'inet6' and fail silently with a debug
> > message.
> Hello,
>
> Please find attached a patch that add such a check for several IPv4
> only scripts. I have only checked and fixed scripts that perform "raw"
> packets manipulation.
>
> The patch also contains error messages standardization, replacing
> nmap.log_write() with hardcoded script name by the more common
> stdnse.print_debug() using the SCRIPT_NAME variable (as noticed in
> [1]).
> The same scripts and functions are concerned by both modifications.

Thanks, Henri. I split the patch into two and committed it.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/