Re: [NSE] mac-geolocation : BSSID (MAC) address based geolocation of WiFi access points

[Djalal Harouni <tixxdz () opendz org>]

On 2011-05-27 21:10:55 -0700, Fyodor wrote:
> On Fri, May 27, 2011 at 01:57:54PM +0200, Gorjan Petrovski wrote:
> > * the nmap.registry[host.ip]["mac-geolocation"] array is read for
> > MACs, which will be filled by snmp-interfaces.nse (with a patch I'm
> > making)
>
> At first I was going to suggest that you use a name relating to what
> is stored in the registry key rather than what script will use the
> information.  But, on the other hand, naming it after the script means
> that the script is in charge of the value.  So mac-geolocation could
> (and maybe should) delete the array values once it is done with them.
> That way they don't bloat the registry more and more as the scan
> progresses.
Yes, if this information is just used by hostrule and portrule scripts,
then we should just put it under nmap.registry[host.ip], and make sure
that this table is a weak table [1]. A better solution would be to
create such a table in nse_main.lua before running the scripts and
convert the appropriate scripts to use it, and if we are not sure if
this table will be collected, then we can make it nil in nse_main.lua
after finishing the host scan.

I'm not speaking about information that is shared between prerule,
hostrule and postrule scripts.

Another important point is that we should perhaps document in the NSEDoc
the information stored in the registry, especially the info that is not
collected, perhaps someone will find this useful and will write a
postrule script that will dump it.

[1] http://www.lua.org/pil/17.html

-- 
tixxdz
http://opendz.org
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/