Nmap Development mailing list archives
Re: [patch] TargetGroup.cc resolver patch
From: Christian Peron <csjp () freebsd org>
Date: Fri, 15 Apr 2011 14:17:02 -0500
FreeBSD; (a number of different versions, but I tested on 8.1.). But we noticed the crash in nmap version 5.51. I am not sure if on other platforms getaddrinfo() initializes the addrinfo pointer to legit storage, regardless of the lookup status, but on FreeBSD, it appears that if the lookup failed, the result would be NULL. On 2011-04-15, at 12:52 PM, David Fifield wrote:
On Fri, Apr 15, 2011 at 11:01:29AM -0500, Christian Peron wrote:Hey guys, I ran into a issues (segfault) when I included addresses that didn't resolve in my targets file. I looked at the code and it appears that we call freeaddrinfo() unconditionally, even if the lookups failed. The patch that I have attached appears to fix it.Thanks for looking at this and providing a patch. This was previously reported and fixed in r22275. What platform did you see the crash on? David Fifield
-- csjp () FreeBSD ORG FreeBSD Committer _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- [patch] TargetGroup.cc resolver patch Christian Peron (Apr 15)
- Re: [patch] TargetGroup.cc resolver patch David Fifield (Apr 15)
- Re: [patch] TargetGroup.cc resolver patch Christian Peron (Apr 15)
- Re: [patch] TargetGroup.cc resolver patch David Fifield (Apr 15)