Re: quake3-master-getservers summary patch

[David Fifield <david () bamsoftware com>]

On Sun, Mar 20, 2011 at 08:00:56PM +0200, Toni Ruottu wrote:
> Here is a patch that extends quake3-master-getservers.nse with a
> function that displays the amount of game servers for each game sorted
> by popularity. It adds a postrule to the script and creates a summary
> for all scanned quake3 master servers. Try running
> nmap -sU -A -PN -p 27950 dpmaster.deathmask.net master.quake3arena.com
> after applying the patch to quake3-master-getservers.nse.

There might be a bug here. It looks like the code is trying to avoid
adding the same (server, protocol) pair twice for the same master. But
it appears that the "if" condition will always be true. Shouldn't the
"filter[key] = true" line be moved inside the "if", like is done with
mfilter below?

What is the purpose of mfilter and mcount?

Please change the output to use the tab library, which will handle all
the space-padding for you.

| quake3-master-getservers:
|   1. Quake III Arena, or Urban Terror (68)   193 server(s)
|   2. unknown (43)                            154 server(s)
|   3. OpenArena (71)                          142 server(s)

Do you know what game protocol 43 is, as it seems to be common?

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/