Re: Minor zenmap feature

[ambarisha b <b.ambarisha () gmail com>]

I attached the revised patch after moving the functionality to the
FileChooser classes.Still every time after a proper save or open,
save_settings(filename) has to be called to save the folder for
future.The only way I could think of to automate it further was to
have a wrapper function over the filechooser.run().But I figured it
would not be so appropriate .I extended only the classes used for open
and save.The configuration file is now saved in ~/.zenmap which is the
user configuration directory.Please check it out once.

I noticed that Open Directory functionality when it tries to load a
directory full of scans pops up alerts when it finds unsuitable
files.It alerts about non xml files also.I thought it would be cooler,
if we put a small check over there to try out only .xml files and
alert if those xmls aren't nmap ones.What do you guys think?

Cheers
Ambarisha

On Tue, Mar 15, 2011 at 3:14 AM, David Fifield <david () bamsoftware com> wrote:
> On Tue, Mar 15, 2011 at 02:47:09AM +0530, ambarisha b wrote:
> > It is being created in the current directory.Yeah, I think that is
> > inappropriate.Its quite simple to move it to ~/ though.I have changed
> > that.
> >
> > About extending classes in FileChoosers.py, do you mean extending the
> > dialog box classes to have an attribute like default directory which
> > could probably be set through the constructor ?And the dialog box
> > loads up using its default directory attribute.Then we can have this
> > functionality as a part of the Dialogue box rather than implementing
> > it each time in MainWindow.py.
>
> Yes, that's what I mean. The default directory wouldn't have to be given
> in the constructor. It could be anything the first time when the saved
> directory is unset, and after that it would load the directory
> automatically (from a configuration file or whatever). In other words,
> I'm proposing that this logic should be inside the FileChooser class and
> happen automatically, not something that happens outside of the
> FileChooser and tells it what directory to open.
>
> David Fifield

Attachment: MainWindow.py.patch
Description:

Attachment: FileChoosers.py.patch
Description:

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/