Re: [Patch] ncat/ncat_exec_win.c

[David Fifield <david () bamsoftware com>]

On Tue, Nov 30, 2010 at 10:13:30AM +0100, Gisle Vanem wrote:
> ncat/ncat_exec_win.c: start_subprocess() refers to an (at first
> pass) unknown structure 'subprocess_info'. When compiling with
> 'g++', this trips an error. Hence the struct-definition should be
> moved further up:
>
> --- ncat/ncat_exec_win.c        Sat Nov 20 16:56:02 2010
> +++ ncat/ncat_exec_win.c     Sat Nov 20 20:11:38 2010
> @@ -98,9 +98,6 @@
>    a thread. Protects subprocesses and subprocesses_max_index. */
> static HANDLE subprocesses_mutex = NULL;
>
> -static int start_subprocess(char *cmdexec, struct subprocess_info *info);
> -static DWORD WINAPI subprocess_thread_func(void *data);
> -
> static int register_subprocess(HANDLE proc);
> static int unregister_subprocess(HANDLE proc);
> static int get_subprocess_slot(void);
> @@ -127,6 +124,9 @@
>     HANDLE child_out_r;
>     HANDLE child_out_w;
> };
> +
> +static int start_subprocess(char *cmdexec, struct subprocess_info *info);
> +static DWORD WINAPI subprocess_thread_func(void *data);
>
> /* Run a child process, redirecting its standard file handles to a socket
>    descriptor. Return the child's PID or -1 on error. */

Thanks. I moved struct subprocess_info up instead of moving
start_subprocess down, but it should still work.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/