Nmap Development mailing list archives
Re: small cosmetic patch against ncat / nping Makefie.in
From: David Fifield <david () bamsoftware com>
Date: Sat, 20 Nov 2010 07:41:51 -0800
On Sat, Nov 20, 2010 at 04:14:14PM +0100, Luis MartinGarcia. wrote:
On 11/20/2010 04:02 PM, olli hauer wrote:The Makefile from ncat creates a directory (DESTDIR)$(pkgdatadir) which is only used if HAVE_OPENSSL is defined, else it keeps empty. The makefile from nping creates a directory "npingdatadir = @datadir@/nping" What's the purpose of this (empty) directory? I can't find any files intstalled into this directory or any usage in the code.Hi Olli, Thanks for reporting this. You are right, there are certainly a few improvements to be made to the Makefiles. Currently Nping does not have any data files so I agree that the there is no need for the data dir to be created. If David is OK with your patches, I'd be happy to apply them.
Yes, they look good. Thanks Olli. David Fifield _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- small cosmetic patch against ncat / nping Makefie.in olli hauer (Nov 20)
- Re: small cosmetic patch against ncat / nping Makefie.in Luis MartinGarcia. (Nov 20)
- Re: small cosmetic patch against ncat / nping Makefie.in David Fifield (Nov 20)
- Re: small cosmetic patch against ncat / nping Makefie.in olli hauer (Nov 22)
- Re: small cosmetic patch against ncat / nping Makefie.in Luis MartinGarcia. (Nov 22)
- Re: small cosmetic patch against ncat / nping Makefie.in Luis MartinGarcia. (Nov 20)