Re: SSL certificate key length in ssl-cert.nse

[David Fifield <david () bamsoftware com>]

On Tue, Oct 19, 2010 at 03:01:44AM -0400, Matt Selsky wrote:
> On Mon, 18 Oct 2010, David Fifield wrote:
>
> > I haven't tested this but it should be something like
> >
> > /* Certificate table is at position -1 */
> > lua_newtable(L);             /* Table T at position -1 */
> > lua_pushstring(pkey_type);   /* T now at position -2 */
> > lua_setfield(L, -2, "type"); /* T now at position -1 */
> > lua_pushnumber(pkey_bits);   /* T now at position -2 */
> > lua_setfield(L, -2, "bits"); /* T now at position -1 */
> > lua_setfield(L, -2, "pubkey");       /* Assign T in the certificate table */
> >
> > You don't need to add all those comments.
>
> I did something similar.
>
> > Yes it does. But you don't have to worry about it. Just define a
> > function pkey_type_to_string that returns "rsa" for EVP_PKEY_RSA, "dsa"
> > for EVP_PKEY_DSA, and so on.
>
> OK.
>
> How does this version look?

Well done. I've committed it.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/