Re: [NSE] Script Pre-scanning and Post-scanning example

[Kris Katterjohn <katterjohn () gmail com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/27/2010 03:19 PM, David Fifield wrote:
> On Fri, Sep 10, 2010 at 12:37:22AM -0500, Kris Katterjohn wrote:
> > On 08/11/2010 01:53 PM, Kris Katterjohn wrote:
> > > On 08/11/2010 08:24 AM, Djalal Harouni wrote:
> > > > Hi Kris,
> > >
> > > > On 2010-08-10 19:19:41 -0500, Kris Katterjohn wrote:
> > > > > * The pre-scan output is not the usual snmp-interfaces output, but rather just
> > > > > a line stating how many targets were successfully added.  The prerule
> > > > > functionality for this script in this patch is to add targets and so I thought
> > > > > the output should pertain solely to that.
> > > > Yes, if the user runs the script scan with --script-args "newtargets"
> > > > then he wants to add targets to Nmap, however if the script argument
> > > > "newtargets" is not present, and the other necessary script arguments that
> > > > will let the script to run in the pre-scanning (prerule) phase, then
> > > > perhaps the user wants simply to see the *output* of the script in the
> > > > pre-scanning phase.
> > >
> > >
> > > OK, that makes sense.  I wasn't thinking about it the right way: I was more
> > > just in a mode of "cool, we can script host discovery".  prerule + target
> > > adding just seemed to be synonymous since I only glanced at commits and emails
> > > but hadn't followed closely (too bad for me).
> >
> > I've been quite busy lately, but I finally got a chance to update this patch.
> >
> > It still adds all of the interface addresses to the target queue, but the
> > script will also run as a prerule even if newtargets isn't specified.  Either
> > way the normal script output is now shown when run as a prerule, and if it
> > adds targets it still also tells how many were successfully added like the
> > previous patch.
>
> Thanks, this is good, please commit it. Just one change, though: make
> the script arguments be snmp-interfaces.host and snmp-interfaces.port.

Cool, I changed the arg names as you requested and committed as r20384.

> David Fifield

Cheers,
Kris Katterjohn

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJMoVcWAAoJEEQxgFs5kUfuJCwP/1iTm3DUlY1mLIi2k8Esvv7b
R0GYV4U46EbrTDcuolcEx/vyDNFPngbuVhIxOFJP3fLlzyDvyYGAft/0d58gOK0s
71559W9KQErLcAp2PxDF8jkRG8esLX66SCIw3FQTt6HiTAYZ9p5O1FCOSQQb5fRl
Yt+6YFxWoNu8DvgDolJ/IUMz8SSwijqVuSyLd8OP0pIYAzcdm7sJzcmzXfyqW9If
t6dvwo75RIcLqMwECkG56+ecVXXy9WUa6n3sTwpSoVEcVH+h3H5aHLzA7SezWsZ6
+vkpYFMELN/+mbVgCKQGmrQuxd+BG9cxwngvzG5FHsr9+TTl6KXJlTqDd6Xh9WrW
uPof8lLrlEXiPrKI67SiKN8tuS3n3fcV3Qm2XPhWkkOHBpuZStM8A5QZq6Yneqak
bxWdllPKqlY4/7UcT74YzKd/N7ddo1lwJhGwfMO+YPpvrRcCRNpEj2KKMFEq8ShS
jWSs8mU4H+sjyy6/QLzk+C1bbJAMtMNngV6CKXdIXnzYWVJ9z60rRCLQ7Pq0F2X0
CpJXNODro056CcKytwufatUk2s4AqCJmvPRb2JhN2fPQsJOCAHUKuI0Ku6CjXodt
dh4nNBOnhwzVkMhgxWQnjtNacVaM8vc2qp1hT9+kiJuYiSL8GbHPH6dVFaJqheO9
80JLIjALxo8UC1ZYAgWA
=WQzY
-----END PGP SIGNATURE-----
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/