Re: [PATCH] nselib rpc.lua

[Patrik Karlsson <patrik () cqure net>]

I've commited this as r17146. I ended up patching only the ReadDir function as the StatFs function is only available 
for version less than 3 where the file handle length is fixed at 32 octets.
Thanks for the bug report Djalal!

//Patrik

On 2 apr 2010, at 17.49, Djalal Harouni wrote:

> BTW patrik if you can commit these changes (nfsv3 fhandles correction) it will
> be cool so i can work on a clean svn copy.
>
> On 2010-04-02 16:41:47 +0100, Djalal Harouni wrote:
> > On 2010-04-02 17:32:08 +0200, Patrik Karlsson wrote:
> > > Hi Djalal,
> > >
> > > On 2 apr 2010, at 17.23, Djalal Harouni wrote:
> > >
> > > > On 2010-04-02 17:10:00 +0200, Patrik Karlsson wrote:
> > > > > I'm having some trouble applying this patch against the rpc.lua in svn.
> > > > > A portion of the patch gets rejected and my diff/patch skills are limited.
> > > > >
> > > > > Can anyone share some diff/patch magic or can you send me a patch against svn Djalal?
> > > > hi patrick i just send you the patch nfsv3_rpc.lua.diff against r17144
> > > > and it's attached to, for the second patch i will probably add some more
> > > > error handling and reporting as suggested by david:
> > > > http://seclists.org/nmap-dev/2010/q1/922
> > > >
> > > > thx
> > >
> > > This patch looks very small compared to the first you sent me which contained both the NFS3 file handle fixes, comm 
> > > class re-design and improved error handling.
> > > I had a quick look at the comm re-design in the previous patch you sent, and it looked quite good. Will it be part 
> > > of the second patch you mentioned?
> > yes, i must rewrite the error handling code.
> >
> > > Oh, and the self.version > 2 patch is incorrect as NFSv3 does not have the STATFS procedure, the procedure 17 has 
> > > been replaced with READDIRPLUS in v3.
> > ah sorry.
> >
> > > > -- 
> > > > Djalal
> > > > http://dzcore.wordpress.com
> > > > <nfsv3_rpc.lua.diff>_______________________________________________
> > > > Sent through the nmap-dev mailing list
> > > > http://cgi.insecure.org/mailman/listinfo/nmap-dev
> > > > Archived at http://seclists.org/nmap-dev/
> > >
> > >
> > > //Patrik
> > >
> > > --
> > > Patrik Karlsson
> > > http://www.cqure.net
> > > http://www.twitter.com/nevdull77
> >
> > -- 
> > Djalal
> > http://dzcore.wordpress.com
>
> -- 
> Djalal
> http://dzcore.wordpress.com
> _______________________________________________
> Sent through the nmap-dev mailing list
> http://cgi.insecure.org/mailman/listinfo/nmap-dev
> Archived at http://seclists.org/nmap-dev/

--
Patrik Karlsson
http://www.cqure.net
http://www.twitter.com/nevdull77





_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/