Re: Raw IP NSE Functionality (Was Re: [NSE] Raw ethernet frame questions ...)

[Kris Katterjohn <katterjohn () gmail com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/11/2010 05:43 PM, Patrick Donnelly wrote:
> I have just some small nitpicking. I compacted your nmap.get_ports
> function to just take the protocol and state as arguments rather than
> a table with the two. I also got rid of the wrapper l_get_ports and
> renamed get_ports to l_get_ports. The new nmap.cc function was
> removed. I changed it to use luaL_checkoption instead.

Thanks!  You forgot the return statement when you switched around the
l_get_ports() functions, but I added that and it seems to work great :)  I
committed it to my branch.

As I didn't have much experience at all in the Lua API stuff, I was mainly
copying the get_port() code for this and was just trying to get it functional
in order to move on with testing the real raw IP stuff.  For whatever reason I
didn't think about going back to it once I learned more Lua/C stuff from doing
and reading more.  For example, I didn't (until now) know about
luaL_checkoption().

> Otherwise it looks good to me :)

Great!

Thanks again,
Kris Katterjohn

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQIcBAEBAgAGBQJLdKAyAAoJEEQxgFs5kUfu7pIP/0YSs30dm3Wu9BbjD7CH8/IB
tnCzglTynJA20FqrYbhd8Q85CggS3aDQyqvvzgsWbJUNuvzfotlHK3pUsa7r4b2f
eJJFUvdSEh50FroxGR2Dr/tVo0tIbblYUaAllL3sc57V6b6TPbY/CFtGjEbz8qjl
UJ9Cxx1FSCjU9PWhUkgMocV0O9MSxDbJIZqIavgdiWvxm5F4U9TJbz4Ig6qh920W
bzXAolvEQeBNu1Re2uP5DGh/c+KE1Jjnn8p9lJ+d884In9W7TmAYngV70htnajmN
LbCW8gMLB+9JPyHwCP41h+H/49NqaS3Xvsa5J5b3if3RsqZzYrCpG9jgfOPVCLNl
VDiZX3xn5xx1J/IKo4BXIHXS8VjB6tLMe7aVGrxYQ2iZcSFhMXpY3pH0Ell9k/Lw
d/NVRHefc8xMdvttSAh6gc0gLei46XVEmlazWjT20hANdbrsC/GRix/lpATpSPyF
r1np62ChUS3AbbJqn9TxDAZxxsWOpSSDUsh+b25wnjghh76ZQKcCXYwEC6tefhlu
RXuABRbeyy9kyTEVIlVp1fk4ejcOxHRCpa79dO0WDjxqXCNvc0VGPILOaVv/vpZ2
PWkDN2IMaWjEkB5ML8mRdelOUttzLRxbfiM3xrohFE3ochYeUAt6zKRWd9nVchb+
lFSYT6PyJBavovtgsyKa
=/fBY
-----END PGP SIGNATURE-----
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/