RE: Suggestion for Docs

["Rob Nicholls" <robert () robnicholls co uk>]

Hi David,

Yes, sorry for the confusion, I should have originally written "we never set
it to 3". At least I got it the right way around in the patch!

I'm pretty sure that it would never be an issue, as our installer always
tries to delete the npf service (for good measure, as it shouldn't exist
anymore) before it creates it again during the installation. By deleting the
service, Windows deletes the npf key in the registry, so that "Start" key no
longer exists and the default value of 3 (I got it right that time! :-D)
would eventually be generated. But we now create the Start key with a value
of 3 straight after the npf service has been (re-)created, just in case. 

Rob

-----Original Message-----
From: nmap-dev-bounces () insecure org [mailto:nmap-dev-bounces () insecure org]
On Behalf Of David Fifield
Sent: 15 January 2010 19:29
To: nmap-dev () insecure org
Subject: Re: Suggestion for Docs

On Thu, Jan 14, 2010 at 11:32:12AM -0000, Rob Nicholls wrote:
> Bug #2: If the GUI installer is used and the user unchecks the box to
start
> WinPcap at startup it will skip the next option and won't start npf as
> potentially requested.

I see this bug and I see that your patch fixes it.

> Bug #3: We only set the registry key to 2, we never set it to 1. This
> *might* mean that the key is never changed from 2 if the user has
previously
> installed WinPcap, despite unchecking the box in our installer during
later
> installations.

Did you mean to write "we never set it to 3"? If I understand your
patch, it sets the value to 3 by default, and then changes it to 2 if
the user checks the box. You're saying that without the patch, if the
registry key already had the value 2 (meaning to start the service at
boot), the Nmap installer would not disable the startup at boot when the
user had left the box unchecked.

I think I get what's going on, I just want to check my possible
misunderstanding between the values 1 and 3. By the way, for anyone else
reading, I found these definitions of the meaning of the values in
winpcap-nmap.nsi:

; Service start options
!define SERVICE_AUTO_START              0x00000002
!define SERVICE_BOOT_START              0x00000000
!define SERVICE_DEMAND_START            0x00000003
!define SERVICE_DISABLED                0x00000004
!define SERVICE_SYSTEM_START            0x00000001

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/


_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/