Nmap Development mailing list archives

Re: [PATCH] fix -Wformat-security warnings


From: David Fifield <david () bamsoftware com>
Date: Wed, 22 Jul 2009 10:03:49 -0600

On Wed, Jul 22, 2009 at 06:48:10PM +0400, Dmitry V. Levin wrote:
gcc -Wformat-security reports several warnings in the nmap-5.00 code, and
one of them (error diagnostics in the scan_engine.cc) really needs to be
fixed.  Proposed patch is attached.

Thank you, I have applied the patch. Those format strings had already
been made safe by Guillaume Rousse in r14432, but I made your changes as
well because the code is shorter and doesn't need the temporary
variable.

David Fifield

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org


Current thread: