Re: Timing race cars with a sundial (-sV match performance)

[Brandon Enright <bmenrigh () ucsd edu>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, 8 May 2009 17:27:58 -0700
Fyodor <fyodor () insecure org> wrote:

...snip lots of talk about match performance...

> > I'm happy to submit a patch that does all of the above if it sounds
> > reasonable.
>
> Yeah, please do create such a patch and check it in.

I just checked in r13629 with my proposed changes.  The log is probably
worthwhile enough to reproduce here:

Log:
I updated our 5 slowest match lines with slightly more efficient
matching strategies.  It is really great that we have so few match
lines that really need any performance attention.  As long as a match
has an anchor (though ^ seems better than $ with PRCE) it should be
fast enough.  We also want to avoid things like
"m|^whatever.*something.*" but we got rid of all of those in a
previous review.

The only "bad" match we have now is:

match ser2net m|\r\nser2net port \d+ device (/dev/[-\w_]+) ...snip...

I think this match should be commented out so that we can get a better
submission.  With a big release coming up so soon though I don't want
to remove any useful features.  I've left a comment about its
performance and maybe myself, Doug, or somebody else will think about
the match more at a later date.


Brandon

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)

iEYEARECAAYFAkotpuQACgkQqaGPzAsl94IKPACfbxwNIO6f8KIeeKlOWl4UOwPc
oOgAn3rmyqeGCpvYj8NNQakJHzeIVenS
=9l/b
-----END PGP SIGNATURE-----

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org