Re: [NSE][PATCH] only show script errors in verbose mode

[David Fifield <david () bamsoftware com>]

On Tue, Sep 23, 2008 at 05:16:05AM -0600, Patrick Donnelly wrote:
> I've been thinking about this problem for a while and have formed a
> fix that should be perfect. I've already committed it after thorough
> testing (r10335). Attached is the svn diff. The patch hooks the
> require function and uses some fancy error handling to check if
> require threw the error.

This looks good. The error messages are accessible enough with -d. In
the case of a catastrophic failure, like the nselib directory not being
present, you get a different, exceptional error message.

I think this is an acceptable solution, though of course others are
welcome to share their opinion. I do think that this needs to be
documented in scripting.xml, that require errors are a special case of
errors that are silently ignored.

David Fifield

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org