Re: Large update/recode of NSE (test please)

[Kris Katterjohn <katterjohn () gmail com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Patrick Donnelly wrote:
> On Wed, May 21, 2008 at 10:02 AM, Kris Katterjohn <katterjohn () gmail com> wrote:
> > Using "--script all" gives me this:
> >
> > SCRIPT ENGINE: Initiating script scanning.
> > SCRIPT ENGINE: Script scanning 127.0.0.1.
> > SCRIPT ENGINE: Could not initialize script rules:
> >        attempt to concatenate a boolean value
> > SCRIPT ENGINE: Script scanning completed.
> > SCRIPT ENGINE: Aborting script scan.
> >
> > but everything seems to work fine with -sC.
>
> Thanks Kris for the report. The attached patch fixes that bug and
> precomputes array lengths (Thanks David Fifield).

That patch broke compilation in your branch.  I've attached a patch to
fix ARRAY_LEN (I added the cast to prevent signedness warnings).

> Cheers,

Thanks,
Kris Katterjohn

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQIVAwUBSDRxgP9K37xXYl36AQKc5xAAu6CKsTjRNxpA5PJbc7fyFXwKzIHBEH0P
tWdyczF0/JAmCuOVtXSkJVh6S+bEdP/peiQaW+vyjGLTbX2kkEI9IXvq1c+hxPTP
XsmTFltW3L1lQW93hliNjrl6xC2tAwPVcsRxIKwPltprIRoU3E3IkqRT5nun32iE
EPvnxK3AjCnM6MLDrSjoZvEZpfUqPnEgYQLISCUMpwZ0vu7LYM45/mC12o4x8Qmc
3+NLE/VLaYy+d2k2NquoReLfIQ6TIBecfvSL+58es5KHsIN5+OsvNFzinpWsT01P
3uafTHeUpqaNanRMlAezxojMxU+OGJV8xIVvrqyFgNuZ3L8CDkFieUVMBd7064k0
n+PIrKN2Wg/lTZngA5mDajZbW4dZSMUzhPRaSCXOwE0Z8Z3ocUNO62tyQEHVSJrE
flLwslnNLYExoHEhTdi6cGk1M7ryDQPHokF66HTmYzvcgBn5bPaiygOqu1FOG8D8
GPc/Xg8lfiiMS/GklRyzudQ4NLKw7T81r9M/q6BacVh1BxMjIAxjuJ8nXmy5FVGt
0qwHhWOY00H6XdQ7dHgHQGrGS6ROZXRgFG8v0HU+XpE6+1zRaSSACAkP9w4liPeM
tsFG09wNn44H6+ibMwrFN6bn0o8U4+kt1IPhE98pPSTZ6AJrTjodZLyJ7RfYVan+
c0hYLutsnUg=
=2scb
-----END PGP SIGNATURE-----

Index: nse_macros.h
===================================================================
--- nse_macros.h        (revision 7602)
+++ nse_macros.h        (working copy)
@@ -40,7 +40,7 @@
        return SCRIPT_ENGINE_ERROR;\
 }
 
-#define ARRAY_LEN(a)  (sizeof(array) / sizeof(array[0]))
+#define ARRAY_LEN(array)  (int)(sizeof(array) / sizeof(array[0]))
 
 #define SCRIPT_ENGINE_VERBOSE(msg) if (o.debugging || o.verbose > 0) {msg};
 #define SCRIPT_ENGINE_DEBUGGING(msg) if (o.debugging) {msg};


_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org