Re: [PATCH] Re: WARNING: Unable to find appropriate interface for system route to ...

[Fyodor <fyodor () insecure org>]

On Sat, Apr 22, 2006 at 12:52:11AM -0400, kx wrote:
> Until someone can point me to a place where they think something else
> is broken, this will fix the warning.   I forced a failure and ran a
> test and the patch worked. Test output below.
>
> NOTE: There is no need to always override the routing table, as
> route_dst() will override the interface when actually sending:
> memcpy(&rnfo->ii, iface, sizeof(rnfo->ii));  This patch just saves us
> from throwing a route away that dnet knows about, but we can't match
> to an interface.
[cut ]
> +   /* We didn't find a matching device and we are about to fail to load this
> +   route into the table.  However, if the user specified an interface, let it
> +   override failing here. */
> +   if (*o.device) {
> +      dcrn->routes[dcrn->numroutes].device = getInterfaceByName(o.device);

Thanks for the patch.  I'm sure people will find it useful.  But I
imagine you would acknowledge that it is just a bandaid which covers
up the issue a little.  Fixing the underlying problem would be far
preferable, as most users aren't going to know enough to use -e
anyway.  If 3.81 worked properly, one would think we could get 4.03 to
do so.  So I think I'll wait on this until we see more reports and are
able to get a better idea what is going on.  But in the meantime, it
is good that people who are annoyed by the issue can apply your patch
(hopefully after they have reported it though!)

Cheers,
-F


_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev