max_sd() upper limit hardcoded 250?

[William McVey <wam () cisco com>]

I grew tired of seeing the:
        WARNING:  Your specified max_parallel_sockets of XXX,
        but your system says it might only give us 250.  Trying anyway
error/warning message, so I looked into some.  This message comes
because the -M option is being compared to the result of max_sd() (from
tcpip.c).  The max_sd function though has a hardcoded limit of 250 with
a comment saying:
        /* I do not feel comfortable going over 255 for now .. */

The max_sd() function is only called in three places.  Once for the -M
warning and twice to set a default max_width for connect scans.  In the
case of the warning, the arbitrary limit of 250 turns the warning into
an incorrect statement (since the system is happy providing more
sockets).  For setting the default max_width, it seems  probably better
to use something like MAX_SOCKETS_ALLOWED, or constructing a new #define
for this value (and ideally taking it out of the max_sd() function).

  -- William



---------------------------------------------------------------------
For help using this (nmap-dev) mailing list, send a blank email to 
nmap-dev-help () insecure org . List run by ezmlm-idx (www.ezmlm.org).