Nmap Development mailing list archives

Superfluous initialization in xml_convert (output.c)


From: NN Poster <nnposter () mailandnews com>
Date: Mon, 22 Apr 2002 23:59:42 -0400

Just a quick nit-picking: Initialization of variable "prevch" on line 224 in 
output.c (2.54BETA32) is redundant. It will never get used because the 
variable is later set on line 226 again.

224c224
<   char *temp, ch=0, prevch = 0, *p;
---
  char *temp, ch=0, prevch, *p;

Of course the code is fully functional as it is and turning on compiler 
optimization will likely cause the initialization to be ignored anyway.

nnposter


---------------------------------------------------------------------
For help using this (nmap-dev) mailing list, send a blank email to 
nmap-dev-help () insecure org . List run by ezmlm-idx (www.ezmlm.org).



Current thread: